Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sysinfo crate to 0.29.6 #685

Merged
merged 8 commits into from
Jul 26, 2023

Conversation

yeastplume
Copy link
Member

Due to changes in rust, compilation was failing on windows and we need to update the sysinfo crate used by tor process handling to the latest. This also comes with API changes, namely that the Process struct can't be instantiated directly and needs to be searched in the System struct.

Changes now needs to be sanity tested on all platforms to ensure tor processes still start and terminate as expected.

Also contains updates to remove deprecation warnings from chrono related updates.

@yeastplume
Copy link
Member Author

Verified tor listener on windows and linux, Mac probably okay but can't check.

@quentinlesceller
Copy link
Member

For some reasons I'm getting a segfault when running this in release mode only on macOS arm64 (m1). Debug mode runs fine.

❯ ./target/release/grin-wallet listen
Password:
zsh: segmentation fault  ./target/release/grin-wallet listen

@quentinlesceller
Copy link
Member

quentinlesceller commented Jul 25, 2023

This:

diff --git a/impls/src/tor/process.rs b/impls/src/tor/process.rs
index ed6627d..f964326 100644
--- a/impls/src/tor/process.rs
+++ b/impls/src/tor/process.rs
@@ -101,7 +101,7 @@ impl TorProcess {
                        working_dir: None,
                        stdout: None,
                        process: None,
-                       sys: System::new_all(),
+                       sys: System::new(),
                }
        }
 

Seems to fix the segfault. But I'm not sure if you need the new_all here.

@yeastplume
Copy link
Member Author

Thanks! No, looks like new_all isn't needed here. Tested linux + windows again with changes.

@yeastplume
Copy link
Member Author

That single failing windows test is driving me insane. I'm just going to merge this and deal with that separately.

@yeastplume yeastplume merged commit c0b7c68 into mimblewimble:master Jul 26, 2023
7 of 9 checks passed
bayk added a commit to mwcproject/mwc-wallet that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants