Use global Tokio runtime #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
reviewed
Dec 11, 2020
There was a problem hiding this comment.
Makes sense to me at a high level.
Ideally somebody with more experience with Tokio can take a look as well.
I don't think the mutex is too much of an issue. I'm guessing most requests are one-by-one anyway and that there will unlikely be much contention (if any).
I'll plan to do some local testing with this today.
quentinlesceller
approved these changes
Dec 11, 2020
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Aug 2, 2024
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Aug 2, 2024
…obal Tokio runtime (mimblewimble#543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the actual bugfix off from #520. Fixes #509.
Instead of creating a tokio runtime for each request, use a global runtime. Unfortunately, until reqwest updates to tokio 0.3, the runtime will have to be behind a
Mutex.