Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the block body for the GRIN wiki website #75

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

marekyggdrasil
Copy link
Contributor

@marekyggdrasil marekyggdrasil commented Aug 21, 2022

@tromp tromp self-assigned this Aug 21, 2022
Copy link
Contributor

@tromp tromp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in-line comments.

@marekyggdrasil
Copy link
Contributor Author

marekyggdrasil commented Aug 24, 2022

Copy link
Contributor

@tromp tromp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing earlier comments.
I have a few more requests for changes. See in-line comments.

@marekyggdrasil
Copy link
Contributor Author

I resolved your comments @tromp could you please take another look?

Copy link
Contributor

@tromp tromp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@marekyggdrasil
Copy link
Contributor Author

Thanks for the review @tromp .

@Anynomouss
Copy link

Is there a good reason why this has not been merged yet...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants