Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new Function feature #2257

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Sep 8, 2024

currently only BM25 Function is supported.

issue: milvus-io/milvus#35853

@mergify mergify bot added the dco-passed label Sep 8, 2024
@buqian-zilliz buqian-zilliz force-pushed the doc-in-pymilvus branch 4 times, most recently from 65c4fea to 26cc8dd Compare September 13, 2024 06:51
@zhengbuqian zhengbuqian changed the title [WIP] support new Function feature support new Function feature Sep 19, 2024
@buqian-zilliz buqian-zilliz force-pushed the doc-in-pymilvus branch 6 times, most recently from f70c29b to eb4ef38 Compare September 19, 2024 08:14
@mergify mergify bot added the ci-passed label Sep 19, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@XuanYang-cn
Copy link
Contributor

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4ed5d3e into milvus-io:master Oct 11, 2024
11 checks passed
@zhengbuqian zhengbuqian deleted the doc-in-pymilvus branch October 11, 2024 06:41
sre-ci-robot pushed a commit that referenced this pull request Oct 12, 2024
this check was added in #2257.

this caused an test in milvus to fail. the test expects the error to be
thrown on server side instead of sdk side. it is ok to check on sdk side
but I choose to remove it to keep the behavior consistent and comfort
the ut without modifying it.

Failed test:
https://github.com/milvus-io/milvus/blob/5b2658327d676453e8a251ffc3273f4a218fb278/tests/python_client/testcases/test_collection.py#L318

Signed-off-by: Buqian Zheng <[email protected]>
@luc42ei
Copy link

luc42ei commented Nov 11, 2024

this feature is not in the 2.4.9 release when I install it w/ poetry. why?

@codingjaguar
Copy link
Contributor

this feature is not in the 2.4.9 release when I install it w/ poetry. why?

The feature is built for the new Milvus 2.5 release (ETA in a week). Given it is a major new feature we launch that in a new major version 2.5 rather than as a patch in 2.4 release. Please check the upcoming Milvus 2.5 to try it out and share feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants