-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support new Function feature #2257
Conversation
65c4fea
to
26cc8dd
Compare
f70c29b
to
eb4ef38
Compare
eb4ef38
to
94a969b
Compare
94a969b
to
2cecf9d
Compare
2cecf9d
to
b6fc492
Compare
Signed-off-by: Buqian Zheng <[email protected]>
b6fc492
to
c37a5af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this check was added in #2257. this caused an test in milvus to fail. the test expects the error to be thrown on server side instead of sdk side. it is ok to check on sdk side but I choose to remove it to keep the behavior consistent and comfort the ut without modifying it. Failed test: https://github.com/milvus-io/milvus/blob/5b2658327d676453e8a251ffc3273f4a218fb278/tests/python_client/testcases/test_collection.py#L318 Signed-off-by: Buqian Zheng <[email protected]>
this feature is not in the 2.4.9 release when I install it w/ poetry. why? |
The feature is built for the new Milvus 2.5 release (ETA in a week). Given it is a major new feature we launch that in a new major version 2.5 rather than as a patch in 2.4 release. Please check the upcoming Milvus 2.5 to try it out and share feedback! |
currently only BM25 Function is supported.
issue: milvus-io/milvus#35853