Add database operations to MilvusClient #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanYang-cn
reviewed
Jun 28, 2024
|
We'll fix the lint issue |
|
Thanks for reviewing, @XuanYang-cn. Added the return type information. |
|
blocked by #2159 |
create_database, drop_database and list_databases Signed-off-by: Ashwin Krishna Kumar <[email protected]>
|
Rebased to include the lint changes |
|
/lgtm |
XuanYang-cn
added
PR | need to cherry-pick to 2.x
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashkrisk, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ashkrisk
added a commit
to ashkrisk/pymilvus
that referenced
this pull request
Jul 2, 2024
Allows the following operations to be performed through the `MilvusClient` interface: - create_database - drop_database - list_databases Resolves milvus-io#2151 Signed-off-by: Ashwin Krishna Kumar <[email protected]>
XuanYang-cn
added
PR | cherry-picked to 2.x
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 4, 2024
Allows the following operations to be performed through the `MilvusClient` interface: - create_database - drop_database - list_databases Resolves #2151 Signed-off-by: Ashwin Krishna Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the following operations to be performed through the
MilvusClientinterface:Resolves #2151