Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept list of single row scipy.sparse object as input for insert/search #2111

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

zhengbuqian
Copy link
Collaborator

previous:

col.insert([[1, 2, 3], csr]) # ok if csr is a 3 row sparse object
col.insert([[1, 2, 3], [csr1, csr2, csr2]]) # this is not ok

now:

col.insert([[1, 2, 3], [csr1, csr2, csr2]]) # ok if csr1/csr2/csr3 are all single row object

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 977c0cd into milvus-io:master Jun 4, 2024
8 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 4, 2024
@zhengbuqian zhengbuqian deleted the sparse-list-csr branch June 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants