modified example_tls1.py through MilvusClient #2065
Conversation
|
Welcome @nish112022! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
|
@nish112022 thanks your contribution. you need to have a sign for the commit to pass the dco check. try to do: and then force to push it |
|
wait for #2068 |
|
@nish112022 please rebase the latest code to pass the code check actions. |
|
/assign @SimFG |
Signed-off-by: Nischay Yadav <[email protected]>
Signed-off-by: Nischay Yadav <[email protected]>
examples/example_tls1.py
Outdated
| print(connections.list_connections()) | ||
| milvus_client = MilvusClient(uri=_URI, | ||
| secure=True, | ||
| server_pem_path="/root/milvus_2.4/milvus/configs/cert/server.pem", |
examples/example_tls1.py
Outdated
| entity = { | ||
| "id_field": i+1, # Assuming id_field is the _COLLECTION_NAME of the field corresponding to the ID | ||
| "float_vector_field": [random.random() for _ in range(_DIM)] | ||
| } |
Signed-off-by: Nischay Yadav <[email protected]>
|
@SimFG Added the fix suggested by you. PTAL |
|
/lgtm |
|
@XuanYang-cn SimFg has reviewed my PR.PTAL |
|
/assign @XuanYang-cn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nish112022, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
Fix bug: add enable_dynamic_field in result of DescribeCollection (milvus-io#1949) 1. modified example_tls1.py through MilvusClient (milvus-io#2065) 2. modified example_tls2.py through MilvusClient (milvus-io#2077) 3. It is to make the example consistent with milvus.io docs Co-Authored-by: zhenshan.cao <[email protected]> Co-Authored-by: Nischay Yadav <[email protected]> Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
added
PR | cherry-picked to 2.x
Fix bug: add enable_dynamic_field in result of DescribeCollection (#1949) 1. modified example_tls1.py through MilvusClient (#2065) 2. modified example_tls2.py through MilvusClient (#2077) 3. It is to make the example consistent with milvus.io docs Signed-off-by: yangxuan <[email protected]> Co-authored-by: zhenshan.cao <[email protected]> Co-authored-by: Nischay Yadav <[email protected]>
It is to make the example consistent with https://milvus.io/docs/tls.md.If these changes look fine I can modify the other example as well