Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: tidy dependencies in tests #1996

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

XuanYang-cn
Copy link
Contributor

  1. Remove dependency of tensorflow, the tests are skipped anyway
  2. Remove dependency of sklearn, legacy codes
  3. Add pymilvus[test] to minimize the test env, remote test_requirements.txt
  4. Update readme to the latest condition

1. Remove dependency of tensorflow, the tests are skipped anyway
2. Remove dependency of sklearn, legacy codes
3. Add pymilvus[test] to minimize the test env, remote
   test_requirements.txt
4. Update readme to the latest condition

Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longjiquan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuanYang-cn,longjiquan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b9a10c9 into milvus-io:master Mar 22, 2024
9 checks passed
@XuanYang-cn XuanYang-cn deleted the update-readme branch March 22, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants