Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to avoid zero value for width #1855

Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Jan 5, 2024

related: #1856

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit da7c3b7 into milvus-io:master Jan 9, 2024
9 checks passed
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Jan 24, 2024
fix: to avoid zero value for width (milvus-io#1855)
fix: change confusing error message (milvus-io#1881)

Co-authored-by: lixinguo <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn added the PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x label Jan 24, 2024
sre-ci-robot pushed a commit that referenced this pull request Jan 24, 2024
fix: to avoid zero value for width (#1855)
fix: change confusing error message (#1881)

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Co-authored-by: lixinguo <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants