Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search result #1748

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix search result #1748

merged 1 commit into from
Oct 23, 2023

Conversation

XuanYang-cn
Copy link
Contributor

  1. Print id instead of pk
  2. Return the correct data type for future.result()

1. Print id instead of pk
2. Return the correct data type for future.result()

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Copy link
Contributor Author

See also: milvus-io/milvus#25504

Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longjiquan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuanYang-cn,longjiquan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0c513eb into milvus-io:master Oct 23, 2023
8 checks passed
@XuanYang-cn XuanYang-cn deleted the fix-details branch October 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants