Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant type inference when insert data #1739

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove redundant type inference when insert data #1739

merged 1 commit into from
Oct 18, 2023

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented Oct 18, 2023

issue #1707

@mergify mergify bot added the dco-passed label Oct 18, 2023
longjiquan
longjiquan approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007 czs007 force-pushed the remove_redundant_infer branch from 8dd7c24 to cf89d18 Compare October 18, 2023 07:49
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 18, 2023
@mergify mergify bot added the ci-passed label Oct 18, 2023
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuanYang-cn,czs007,longjiquan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1bd1215 into milvus-io:master Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan approved these changes

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@longjiquan longjiquan

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czs007 @XuanYang-cn @sre-ci-robot @longjiquan