List indexes by field name #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longjiquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
longjiquan
force-pushed
the
list-index-by-field
branch
from
1c38864 to
812d298
Compare
Signed-off-by: longjiquan <[email protected]>
longjiquan
force-pushed
the
list-index-by-field
branch
from
812d298 to
0753fc1
Compare
longjiquan
added a commit
to longjiquan/pymilvus
that referenced
this pull request
Apr 23, 2023
Signed-off-by: longjiquan <[email protected]>
|
/lgtm |
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 23, 2023
Signed-off-by: longjiquan <[email protected]>
1 task
|
I know this is closed but why is the field_name under kwargs? It might be better to expose it as a parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #1361