fix can't insert string == schema max len #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izapolsk Please sign off this PR following the DCO robots' instruction https://github.com/milvus-io/pymilvus/pull/1304/checks?check_run_id=11322034734 |
izapolsk
force-pushed
the
fix/varchar-max-len
branch
2 times, most recently
from
d0a7355 to
cf23dbc
Compare
|
@XuanYang-cn, done, thank you |
…with len same as varchar max len. Signed-off-by: Ievgen Zapolskyi <[email protected]>
izapolsk
force-pushed
the
fix/varchar-max-len
branch
from
cf23dbc to
6fbccb7
Compare
|
@izapolsk Thanks for this contribution |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: izapolsk, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Mar 1, 2023
- fix describe/list rg err msg (milvus-io#1291) - fix load collection (milvus-io#1293) - Change default connect timeout to 10s (milvus-io#1294) - add param check (milvus-io#1297) - Support rename collection API (milvus-io#1299) - expose rg info in replica (milvus-io#1305) - fix check string max len (milvus-io#1304) - Support upsert (milvus-io#1303) - expose rg info (milvus-io#1307) - Add ignore_growing option for query and search (milvus-io#1286) - refine rg api (milvus-io#1310) - Fix some error (milvus-io#1312) - Add GPU index types (milvus-io#1314) Signed-off-by: yangxuan <[email protected]> Co-authored-by: Wei Liu <[email protected]> Co-authored-by: jaime <[email protected]> Co-authored-by: Ievgen Zapolskyi <[email protected]> Co-authored-by: lixinguo <[email protected]> Co-authored-by: aoiasd <[email protected]> Co-authored-by: Yudong Cai <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 1, 2023
- fix describe/list rg err msg (#1291) - fix load collection (#1293) - Change default connect timeout to 10s (#1294) - add param check (#1297) - Support rename collection API (#1299) - expose rg info in replica (#1305) - fix check string max len (#1304) - Support upsert (#1303) - expose rg info (#1307) - Add ignore_growing option for query and search (#1286) - refine rg api (#1310) - Fix some error (#1312) - Add GPU index types (#1314) Co-authored-by: wei liu <[email protected]> Co-authored-by: jaime <[email protected]> Co-authored-by: Ievgen Zapolskyi <[email protected]> Co-authored-by: lixinguo <[email protected]> Co-authored-by: aoiasd <[email protected]> Co-authored-by: Yudong Cai <[email protected]>
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Mar 7, 2023
…with len same as varchar max len. (milvus-io#1304) Signed-off-by: Ievgen Zapolskyi <[email protected]>
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Mar 7, 2023
Otherwise it's impossible to insert string with len same as varchar max len. (milvus-io#1304) Co-authored-by: Ievgen Zapolskyi <[email protected]> Signed-off-by: yangxuan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a quick fix for bug #1143