Optimize some low efficient code #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliu-z
force-pushed
the
fix_some_low_effienct_code
branch
from
1133eb5 to
8b06225
Compare
Signed-off-by: Li Liu <[email protected]>
liliu-z
force-pushed
the
fix_some_low_effienct_code
branch
from
8b06225 to
9b7d462
Compare
|
Marvelous! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Nov 24, 2022
- Modify bulkinsert example (milvus-io#1218) - Fix the partition example (milvus-io#1219) - Fix error message for primary key type (milvus-io#1222) - Optimize some low efficient code (milvus-io#1223) - Change doc string of Collection init and property (milvus-io#1220) - Fix mutation results print error (milvus-io#1226) - Update docs for collection (milvus-io#1225) - Modify bulkinsert example (milvus-io#1228) - Add the example comments for rbac methods (milvus-io#1235) - Add documentation for flush and set_properties (milvus-io#1236) - Enhance expression of search (milvus-io#1237) - Update docs for collection/partition search (milvus-io#1238) - Update docs for Collection (milvus-io#1242) Co-Authored-By: yhmo <[email protected]> Co-Authored-By: SimFG <[email protected]> Co-Authored-By: yangxuan <[email protected]> Co-Authored-By: Li Liu <[email protected]> Co-Authored-By: yhmo <[email protected]> Signed-off-by: yangxuan <[email protected]> Signed-off-by: yhmo <[email protected]>
Merged
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 24, 2022
- Modify bulkinsert example (#1218) - Fix the partition example (#1219) - Fix error message for primary key type (#1222) - Optimize some low efficient code (#1223) - Change doc string of Collection init and property (#1220) - Fix mutation results print error (#1226) - Update docs for collection (#1225) - Modify bulkinsert example (#1228) - Add the example comments for rbac methods (#1235) - Add documentation for flush and set_properties (#1236) - Enhance expression of search (#1237) - Update docs for collection/partition search (#1238) - Update docs for Collection (#1242) Co-Authored-By: yhmo <[email protected]> Co-Authored-By: SimFG <[email protected]> Co-Authored-By: yangxuan <[email protected]> Co-Authored-By: Li Liu <[email protected]> Co-Authored-By: yhmo <[email protected]> Signed-off-by: yangxuan <[email protected]> Signed-off-by: yhmo <[email protected]> Signed-off-by: yangxuan <[email protected]> Signed-off-by: yhmo <[email protected]> Co-authored-by: groot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Li Liu [email protected]
This PR fix some low efficient code:
to_dict()of a collection at construction time and store it for search use.if elseto check param.async + getFor performance enhancement, I did some test in my 2C8M container:
Pymilvus: Set
grpcto return empty response immediately, the QPS ofPymilvusincrease from ~1200 to ~2100, increased about 75%End 2 End: For nq1 serial execution, latency improved ~10%.
Notice: Still lots of similar style in other parts of the code, like deep copy,
to_dict()call,if elseparam check and mixed sync/async call. We need to fix them all if needed.