Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION]: Loosen environs package requirement #2166

Open
1 task done
mbadams5 opened this issue Jul 3, 2024 · 3 comments
Open
1 task done

[QUESTION]: Loosen environs package requirement #2166

mbadams5 opened this issue Jul 3, 2024 · 3 comments
Assignees
@laipz8200
Labels
kind/question A question to answer
Milestone
PyMilvus 2.4.5

Comments

@mbadams5
Copy link

mbadams5 commented Jul 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What is your question?

Can the environs requirement be loosened from "environs<=9.5.0"?
This is causing pip conflicts with some other packages that set environs>=11.0.0.

Anything else?

No response
@mbadams5 mbadams5 added the kind/question A question to answer label Jul 3, 2024
@XuanYang-cn XuanYang-cn self-assigned this Jul 5, 2024
@XuanYang-cn XuanYang-cn added this to the PyMilvus 2.4.5 milestone Jul 5, 2024
@laipz8200
Copy link
Contributor

Hi @XuanYang-cn! I think we could replace environs with the more lightweight python-dotenv, or at least avoid using env.read_env().

As an SDK, pymilvus loads the entire .env file in the working directory into os.environ when it is imported, which can easily destroy the environment of projects that use it.

If you permit, I can make this change. Looking forward to your response.

@XuanYang-cn
Copy link
Contributor

@laipz8200 cool, please take this issue
/assign @laipz8200
/unassign

@laipz8200 laipz8200 mentioned this issue Jul 22, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Oct 8, 2024
@laipz8200
feat(pymilvus/settings.py): Load configuration without altering the e…
d255ef1 
…nvironment (#2192)

related #2166.

This PR will replace `environs` with the more lightweight
`python-dotenv`. It can load configuration from the dot env file without
altering the system environment.

---------

Signed-off-by: -LAN- <[email protected]>
hasansustcse13 pushed a commit to hasansustcse13/pymilvus that referenced this issue Oct 9, 2024
@laipz8200
feat(pymilvus/settings.py): Load configuration without altering the e…
a75dac1 
…nvironment (milvus-io#2192)

related milvus-io#2166.

This PR will replace `environs` with the more lightweight
`python-dotenv`. It can load configuration from the dot env file without
altering the system environment.

---------

Signed-off-by: -LAN- <[email protected]>
Signed-off-by: hasan <[email protected]>
@ZinkLu
Copy link

ZinkLu commented Oct 9, 2024

Any progress? pymilvus 2.4.7 still depends on environs<=9.5.0

XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Nov 15, 2024
@brunocfnba @laipz8200
@czs007 @CaoHaiNam @XuanYang-cn
Multi cherry picks from master branch
c497eb6 
- Added grpc as a valid protocol for uri (milvus-io#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170)
- feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192)
- feat: Add compact, get_server_version and flush api (milvus-io#2326)
- Fix typo and correct grammar (milvus-io#2333)
- Update return type of describe_role to Dict (milvus-io#2337)
- enhance: Reorganize the examples (milvus-io#2340)

Related: milvus-io#2166, milvus-io#2325, milvus-io#2332

Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: dependabot[bot] <[email protected]>
Co-authored-by: -LAN- <[email protected]>
Co-authored-by: zhenshan.cao <[email protected]>
Co-authored-by: NamCaoHai <[email protected]>
Co-authored-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Nov 15, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Nov 15, 2024
@brunocfnba @laipz8200
@czs007 @CaoHaiNam @XuanYang-cn
Multi cherry picks from master branch
09dc873 
- Added grpc as a valid protocol for uri (milvus-io#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170)
- feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192)
- feat: Add compact, get_server_version and flush api (milvus-io#2326)
- Fix typo and correct grammar (milvus-io#2333)
- Update return type of describe_role to Dict (milvus-io#2337)
- enhance: Reorganize the examples (milvus-io#2340)

Related: milvus-io#2166, milvus-io#2325, milvus-io#2332

Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: dependabot[bot] <[email protected]>
Co-authored-by: -LAN- <[email protected]>
Co-authored-by: zhenshan.cao <[email protected]>
Co-authored-by: NamCaoHai <[email protected]>
Co-authored-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 25, 2024
@XuanYang-cn @brunocfnba
@laipz8200 @czs007 @CaoHaiNam
Multi cherry picks from master branch (#2349)
29bef71 
- Added grpc as a valid protocol for uri (#2090)
- build(deps): bump urllib3 from 1.26.18 to 1.26.19 (#2140)
- build(deps): bump certifi from 2023.7.22 to 2024.7.4 (#2170)
- feat(pymilvus/settings.py): Load configuration without altering the
environment (#2192)
- feat: Add compact, get_server_version and flush api (#2326)
- Fix typo and correct grammar (#2333)
- Update return type of describe_role to Dict (#2337)
- enhance: Reorganize the examples (#2340)

Related: #2166, #2325, #2332

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: Bruno Faria <[email protected]>
Co-authored-by: dependabot[bot] <[email protected]>
Co-authored-by: -LAN- <[email protected]>
Co-authored-by: zhenshan.cao <[email protected]>
Co-authored-by: NamCaoHai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laipz8200 laipz8200

Labels
kind/question A question to answer
Projects
None yet
Milestone
PyMilvus 2.4.5
Development

No branches or pull requests
4 participants
@mbadams5 @laipz8200 @ZinkLu @XuanYang-cn