Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: enable reduce_stop_for_best for iterator #1830

Closed
1 task done
MrPresent-Han opened this issue Dec 27, 2023 · 1 comment
Closed
1 task done

[Bug]: enable reduce_stop_for_best for iterator #1830

MrPresent-Han opened this issue Dec 27, 2023 · 1 comment

Comments

@MrPresent-Han
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

In the past, without using reduce_stop_for_best, iterator may get incorrect results from query node due to duplicated ids, which result in iteration ending ahead

Expected Behavior

No response

Steps/Code To Reproduce behavior

No response

Environment details

- Hardware/Softward conditions (OS, CPU, GPU, Memory):
- Method of installation (Docker, or from source):
- Milvus version (v0.3.1, or v0.4.0):
- Milvus configuration (Settings you made in `server_config.yaml`):

Anything else?

No response
MrPresent-Han added a commit to MrPresent-Han/pymilvus that referenced this issue Dec 27, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(milvus-io#1830)
b850591 
Signed-off-by: MrPresent-Han <[email protected]>
MrPresent-Han added a commit to MrPresent-Han/pymilvus that referenced this issue Dec 27, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(milvus-io#1830)
43053bd 
Signed-off-by: MrPresent-Han <[email protected]>
MrPresent-Han added a commit to MrPresent-Han/pymilvus that referenced this issue Dec 27, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(milvus-io#1830)
dcbe53b 
Signed-off-by: MrPresent-Han <[email protected]>
MrPresent-Han added a commit to MrPresent-Han/pymilvus that referenced this issue Dec 27, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(milvus-io#1830)
dcc57d6 
Signed-off-by: MrPresent-Han <[email protected]>
This was referenced Dec 27, 2023
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 28, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(#1830) (#1831)
2b5a27d 
Signed-off-by: MrPresent-Han <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 28, 2023
@MrPresent-Han
set reduce_stop_for_best for iterator by default(#1830) (#1832)
a38a502 
Signed-off-by: MrPresent-Han <[email protected]>
@XuanYang-cn
Copy link
Contributor

close for done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XuanYang-cn @MrPresent-Han