Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Reduce mutex contention in datacoord meta #38904

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

bigsheeper
Copy link
Contributor

  1. Using secondary index to avoid retrieving all segments at GetSegmentsChanPart.
  2. Perform batch SetAllocations to reduce the number of times the meta lock is acquired.

issue: #37630

pr: #38219

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 1, 2025 08:21
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (5199415) to head (1f8e984).
Report is 3 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38904       +/-   ##
===========================================
+ Coverage   69.58%   81.06%   +11.47%     
===========================================
  Files         297     1399     +1102     
  Lines       26557   196789   +170232     
===========================================
+ Hits        18480   159521   +141041     
- Misses       8077    31657    +23580     
- Partials        0     5611     +5611     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.58% <ø> (ø)
Go 83.02% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_clustering.go 75.48% <100.00%> (ø)
internal/datacoord/compaction_policy_single.go 61.00% <100.00%> (ø)
internal/datacoord/compaction_trigger.go 85.53% <100.00%> (ø)
internal/datacoord/meta.go 89.66% <100.00%> (ø)
internal/datacoord/segment_info.go 84.72% <100.00%> (ø)

... and 1097 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 14, 2025
@sre-ci-robot sre-ci-robot merged commit 2e4a105 into milvus-io:2.5 Jan 14, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants