-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5] Remove frequently updating metric to avoid mutex contention #38778
base: 2.5
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #38778 +/- ##
===========================================
- Coverage 81.05% 69.45% -11.61%
===========================================
Files 1383 294 -1089
Lines 195503 26419 -169084
===========================================
- Hits 158472 18349 -140123
+ Misses 31457 8070 -23387
+ Partials 5574 0 -5574
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bigsheeper cpp-unit-test check failed, comment |
Signed-off-by: bigsheeper <[email protected]>
9e804d9
to
be00199
Compare
issue: #37630
Reduce the frequency of
updateIndexTasksMetrics
to avoid holding the mutex for long periods.pr: #38775