Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Remove frequently updating metric to avoid mutex contention #38778

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

pr: #38775

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (6fa096e) to head (be00199).

❗ There is a different number of reports uploaded between BASE (6fa096e) and HEAD (be00199). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6fa096e) HEAD (be00199)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38778       +/-   ##
===========================================
- Coverage   81.05%   69.45%   -11.61%     
===========================================
  Files        1383      294     -1089     
  Lines      195503    26419   -169084     
===========================================
- Hits       158472    18349   -140123     
+ Misses      31457     8070    -23387     
+ Partials     5574        0     -5574     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.45% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1090 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 26, 2024
@bigsheeper bigsheeper changed the title fix: [2.5] Fix index meta mutex contention fix: [2.5] Remove frequently updating metric to avoid mutex contention Dec 31, 2024
@mergify mergify bot removed the ci-passed label Dec 31, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants