Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] privilege group privileges granted from ClusterAdmin permission denied #38530

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #38514
related: #38460

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (6f573f6) to head (118c328).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38530      +/-   ##
==========================================
+ Coverage   72.15%   80.40%   +8.25%     
==========================================
  Files        1077     1077              
  Lines      169342   169342              
==========================================
+ Hits       122185   136159   +13974     
+ Misses      42685    28714   -13971     
+ Partials     4472     4469       -3     
Files with missing lines Coverage Δ
pkg/util/constant.go 96.82% <ø> (ø)

... and 223 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@liliu-z
Copy link
Member

liliu-z commented Dec 18, 2024

/approve

@liliu-z
Copy link
Member

liliu-z commented Dec 18, 2024

/lgtm

@liliu-z
Copy link
Member

liliu-z commented Dec 18, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6364e32 into milvus-io:2.4 Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants