Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search-group-by failed to get data from multi-chunked-segment(##… #38383

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

MrPresent-Han
Copy link
Contributor

related: #38343

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 11, 2024
Copy link
Contributor

mergify bot commented Dec 11, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 11, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (dc85d8e) to head (05d9dfd).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
.../src/exec/operator/groupby/SearchGroupByOperator.h 83.33% 3 Missing ⚠️
internal/core/src/index/ScalarIndex.h 0.00% 1 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.h 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38383      +/-   ##
==========================================
+ Coverage   78.82%   80.93%   +2.10%     
==========================================
  Files        1368     1376       +8     
  Lines      191711   193063    +1352     
==========================================
+ Hits       151114   156247    +5133     
+ Misses      35116    31301    -3815     
- Partials     5481     5515      +34     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.93% <77.27%> (+0.01%) ⬆️
Go 83.04% <72.64%> (+2.50%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/index/ScalarIndex.h 25.00% <0.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 51.61% <66.66%> (+6.78%) ⬆️
.../src/exec/operator/groupby/SearchGroupByOperator.h 88.88% <83.33%> (+3.17%) ⬆️

... and 254 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 12, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added area/test sig/testing size/XL Denotes a PR that changes 500-999 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 12, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 12, 2024
@MrPresent-Han
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Dec 12, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

rerun go-sdk

@MrPresent-Han
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 12, 2024
@sunby
Copy link
Contributor

sunby commented Dec 13, 2024

Code looks good to me but we need more unittests to cover this function

@MrPresent-Han
Copy link
Contributor Author

I will give more unit test for this function next week

@sunby
Copy link
Contributor

sunby commented Dec 13, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c1f9158 into milvus-io:master Dec 13, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants