-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: search-group-by failed to get data from multi-chunked-segment(##… #38383
fix: search-group-by failed to get data from multi-chunked-segment(##… #38383
Conversation
e9d6e60
to
28e4a88
Compare
@MrPresent-Han E2e jenkins job failed, comment |
@MrPresent-Han go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38383 +/- ##
==========================================
+ Coverage 78.82% 80.93% +2.10%
==========================================
Files 1368 1376 +8
Lines 191711 193063 +1352
==========================================
+ Hits 151114 156247 +5133
+ Misses 35116 31301 -3815
- Partials 5481 5515 +34
|
28e4a88
to
a970301
Compare
@MrPresent-Han go-sdk check failed, comment |
…lvus-io#38343) Signed-off-by: MrPresent-Han <[email protected]>
b70f30c
to
05d9dfd
Compare
rerun ut |
@MrPresent-Han E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun go-sdk |
rerun ut |
Code looks good to me but we need more unittests to cover this function |
I will give more unit test for this function next week |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related: #38343