Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Reduce memory usage of BF in DataNode and QueryNode #38215

Open
wants to merge 3 commits into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. DataNode: Skip generating BF during the insert phase (BF will be regenerated during the sync phase).
  2. QueryNode: Skip generating or maintaining BF for growing segments; deletion checks will be handled in the segcore.

issue: #37630

pr: #38129

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (bd08b3b) to head (882e623).
Report is 7 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/writebuffer/l0_write_buffer.go 16.66% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38215       +/-   ##
===========================================
+ Coverage   64.28%   83.58%   +19.30%     
===========================================
  Files         268      806      +538     
  Lines       26479   141649   +115170     
===========================================
+ Hits        17021   118393   +101372     
- Misses       9458    18807     +9349     
- Partials        0     4449     +4449     
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 67.93% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.36% <100.00%> (ø)
internal/datanode/writebuffer/l0_write_buffer.go 43.78% <16.66%> (ø)

... and 1071 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@czs007 czs007 removed this from the 2.4.18 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants