enhance: Enable score based balance channel policy #38143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
weiliu1031
force-pushed
the
enable_scored_based_balance_channel
branch
from
50bd48a to
e175a84
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38143 +/- ##
==========================================
+ Coverage 81.04% 81.06% +0.01%
==========================================
Files 1372 1372
Lines 191677 191875 +198
==========================================
+ Hits 155346 155536 +190
- Misses 30828 30829 +1
- Partials 5503 5510 +7
|
|
/run-cpu-e2e |
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
enable_scored_based_balance_channel
branch
from
e175a84 to
8126aac
Compare
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
czs007
pushed a commit
that referenced
this pull request
Dec 9, 2024
issue: #38142 current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. pr: #38143 --------- Signed-off-by: bigsheeper <[email protected]> Co-authored-by: Wei Liu <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
enable_scored_based_balance_channel
branch
from
8126aac to
d001eb8
Compare
|
/lgtm |
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Dec 11, 2024
issue: milvus-io#38142 current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. --------- Signed-off-by: Wei Liu <[email protected]>
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Dec 11, 2024
issue: milvus-io#38142 current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. --------- Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 13, 2024
issue: #38142 pr: #38143 current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered. This PR enable score based balance channel policy, to achieve: 1. distribute all channels evenly across multiple querynodes 2. distribute each collection's channel evenly across multiple querynodes. --------- Signed-off-by: Wei Liu <[email protected]>
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #38142
current balance channel policy only consider current collection's distribution, so if all collections has 1 channel, and all channels has been loaded on same querynode, after querynode num increase, balance channel won't be triggered.
This PR enable score based balance channel policy, to achieve: