Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add switch for local rpc enabled #37985

Merged
merged 2 commits into from
Nov 26, 2024
Merged

enhance: add switch for local rpc enabled #37985

merged 2 commits into from
Nov 26, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 25, 2024

issue: #33285

  • Add switch for local rpc

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (27c22d1) to head (553f464).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/coordinator/coordclient/registry.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37985       +/-   ##
===========================================
+ Coverage   68.87%   81.04%   +12.16%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190788   +165307     
===========================================
+ Hits        17551   154621   +137070     
- Misses       7930    30669    +22739     
- Partials        0     5498     +5498
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.21% <75.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.36% <100.00%> (ø)
internal/coordinator/coordclient/registry.go 88.46% <0.00%> (ø)

... and 1069 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one branch from fb7e097 to c022cb1 Compare November 25, 2024 08:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor

rerun go-sdk

@jaime0815
Copy link
Contributor

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh mentioned this pull request Nov 26, 2024
Merged
@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one branch from 09a0516 to 553f464 Compare November 26, 2024 01:21
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@jaime0815
Copy link
Contributor

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 26, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2b4f211 into milvus-io:master Nov 26, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
@chyezh
enhance: add switch for local rpc enabled (#37973)
73bab0f 
issue: #33285
pr: #37985

- Add switch for local rpc

---------

Signed-off-by: chyezh <[email protected]>
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@chyezh @JsDove
enhance: add switch for local rpc enabled (milvus-io#37985)
222c1c5 
issue: milvus-io#33285

- Add switch for local rpc

---------

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@jaime0815 jaime0815

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @jaime0815 @sre-ci-robot