Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add thread watcher to provide actual thread num #37905

Merged
merged 4 commits into from
Nov 22, 2024
Merged

enhance: Add thread watcher to provide actual thread num #37905

merged 4 commits into from
Nov 22, 2024
+121 −9

Conversation

congqixia
Copy link
Contributor

Related to #37904

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
@congqixia
add metrics updates
b0d4dbc 
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Commit dependency change
4d2bbeb 
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 21, 2024
@congqixia
Fix typo
2804f39 
Signed-off-by: Congqi Xia <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.70270% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (70e6a00) to head (2804f39).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/metrics/thread.go 0.00% 36 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37905   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files        1357     1358    +1     
  Lines      190143   190232   +89     
=======================================
+ Hits       154095   154173   +78     
- Misses      30584    30602   +18     
+ Partials     5464     5457    -7
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.21% <2.63%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/metrics/info_metrics.go 100.00% <ø> (ø)
pkg/metrics/metrics.go 100.00% <100.00%> (ø)
internal/util/metrics/thread.go 0.00% <0.00%> (ø)

... and 36 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify mergify bot added the ci-passed label Nov 21, 2024
LoveEachDay
LoveEachDay approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cfa1f1f into milvus-io:master Nov 22, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 22, 2024
@congqixia
enhance: Add thread watcher to provide actual thread num (milvus-io#3…
528a0f8 
…7905)

Related to milvus-io#37904

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@LoveEachDay LoveEachDay

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @LoveEachDay