Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Reduce segmentManager lock granularity #37869

Merged
merged 13 commits into from
Dec 6, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Nov 21, 2024

Use a channel level key lock for segments in segmentManager.

issue: #37633, #37630

pr: #37836

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Nov 21, 2024
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper changed the title enhance: [2.4] Optimize segmentManager segments enhance: [2.4] Reduce segmentManager lock granularity Nov 22, 2024
@bigsheeper bigsheeper force-pushed the 2411-refine-segment-mgr-2.4 branch from 6a6df75 to 61e2351 Compare November 22, 2024 10:18
Copy link
Contributor

mergify bot commented Nov 22, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.4.18 milestone Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Nov 29, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 87.12871% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (febed0a) to head (ae800ed).

Current head ae800ed differs from pull request most recent head e7ff7be

Please upload reports for the commit e7ff7be to get more accurate results.

Files with missing lines Patch % Lines
internal/datacoord/segment_manager.go 89.18% 13 Missing and 7 partials ⚠️
internal/datacoord/services.go 64.70% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #37869       +/-   ##
===========================================
+ Coverage   70.40%   80.59%   +10.19%     
===========================================
  Files        1074     1073        -1     
  Lines      168099   167716      -383     
===========================================
+ Hits       118353   135179    +16826     
+ Misses      45291    28116    -17175     
+ Partials     4455     4421       -34     
Files with missing lines Coverage Δ
internal/datacoord/services.go 85.26% <64.70%> (+0.23%) ⬆️
internal/datacoord/segment_manager.go 87.30% <89.18%> (-3.97%) ⬇️

... and 313 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 2, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 3, 2024
Copy link
Contributor

mergify bot commented Dec 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 3, 2024
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 6, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 12cc500 into milvus-io:2.4 Dec 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants