Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [skip e2e] update mergify to support macos 13 job #37844

Merged

Conversation

zhikunyao
Copy link
Collaborator

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 20, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 20, 2024
Copy link
Contributor

mergify bot commented Nov 20, 2024

@zhikunyao

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@zhikunyao
Copy link
Collaborator Author

/kind improvment

@sre-ci-robot
Copy link
Contributor

@zhikunyao: The label(s) kind/improvment cannot be applied, because the repository doesn't have them.

In response to this:

/kind improvment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhikunyao
Copy link
Collaborator Author

/assign @yellow-shine

@zhikunyao zhikunyao changed the title [skip e2e] Update mergify to support macos 13 job [skip e2e] enhance: update mergify to support macos 13 job Nov 20, 2024
@yellow-shine yellow-shine changed the title [skip e2e] enhance: update mergify to support macos 13 job enhance: [skip e2e] update mergify to support macos 13 job Nov 20, 2024
@yellow-shine
Copy link
Collaborator

/lgtm

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 20, 2024
@zhikunyao
Copy link
Collaborator Author

/assign @yanliang567

@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567, zhikunyao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7144219 into milvus-io:master Nov 20, 2024
4 checks passed
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants