Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace outer lock with concurrent map #37817

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37493

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 19, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yangxuan <[email protected]>
Copy link
Contributor

mergify bot commented Nov 19, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.92%. Comparing base (f3a36f8) to head (0c345bb).
Report is 4 commits behind head on master.

Current head 0c345bb differs from pull request most recent head 888f7a3

Please upload reports for the commit 888f7a3 to get more accurate results.

Files with missing lines Patch % Lines
internal/flushcommon/writebuffer/manager.go 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37817      +/-   ##
==========================================
+ Coverage   81.03%   82.92%   +1.88%     
==========================================
  Files        1357     1068     -289     
  Lines      190178   164654   -25524     
==========================================
- Hits       154118   136536   -17582     
+ Misses      30595    22657    -7938     
+ Partials     5465     5461       -4     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.21% <93.93%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/flushcommon/writebuffer/write_buffer.go 73.40% <100.00%> (+0.96%) ⬆️
internal/flushcommon/writebuffer/manager.go 91.71% <92.30%> (-1.37%) ⬇️

... and 317 files with indirect coverage changes

---- 🚨 Try these New Features:

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@liliu-z
Copy link
Member

liliu-z commented Nov 20, 2024

/run-cpu-e2e

@liliu-z
Copy link
Member

liliu-z commented Nov 20, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@liliu-z
Copy link
Member

liliu-z commented Nov 20, 2024

/run-cpu-e2e

@liliu-z
Copy link
Member

liliu-z commented Nov 20, 2024

rerun cpp-unit-test

@liliu-z
Copy link
Member

liliu-z commented Nov 20, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 20, 2024
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 70e6a00 into milvus-io:master Nov 21, 2024
14 of 15 checks passed
@XuanYang-cn XuanYang-cn deleted the enhance-log-usage branch November 21, 2024 08:15
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 21, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 22, 2024
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 29, 2024
bigsheeper pushed a commit to bigsheeper/milvus that referenced this pull request Dec 6, 2024
czs007 pushed a commit that referenced this pull request Dec 9, 2024
See also: #37493
pr: #37817

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: XuanYang-cn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants