Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use batch to speed up list collections from meta kv #37752

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #36228
pr: #37742

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (13f83df) to head (a2bdac5).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/metastore/kv/rootcoord/kv_catalog.go 88.46% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37752      +/-   ##
==========================================
- Coverage   72.28%   72.27%   -0.01%     
==========================================
  Files        1069     1069              
  Lines      166874   166943      +69     
==========================================
+ Hits       120619   120663      +44     
- Misses      41853    41873      +20     
- Partials     4402     4407       +5     
Files with missing lines Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 82.09% <88.46%> (-0.84%) ⬇️

... and 38 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.16 milestone Nov 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 79f676e into milvus-io:2.4 Nov 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants