Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove segment-level tag from monitoring metrics #37696

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bigsheeper
Copy link
Contributor

When there are a large number of segments, the metrics consume a lot of memory. This PR Remove segment-level tag from monitoring metrics.

issue: #37636

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (1b4f7e3) to head (2f9949b).
Report is 59 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1b4f7e3) and HEAD (2f9949b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b4f7e3) HEAD (2f9949b)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37696       +/-   ##
===========================================
- Coverage   80.63%   68.64%   -12.00%     
===========================================
  Files        1357      290     -1067     
  Lines      190463    25457   -165006     
===========================================
- Hits       153589    17476   -136113     
+ Misses      31462     7981    -23481     
+ Partials     5412        0     -5412     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.64% <ø> (ø)
Go ∅ <ø> (∅)

see 1067 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify mergify bot added the ci-passed label Nov 14, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3df2c92 into milvus-io:master Nov 16, 2024
18 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 16, 2024
When there are a large number of segments, the metrics consume a lot of
memory. This PR Remove segment-level tag from monitoring metrics.

issue: #37636

pr: #37696

Signed-off-by: bigsheeper <[email protected]>
@congqixia congqixia added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants