Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add search params in search request in restful(#36304) #37673

Merged
merged 3 commits into from
Nov 15, 2024
Merged

enhance: add search params in search request in restful(#36304) #37673

merged 3 commits into from
Nov 15, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Nov 14, 2024 •
edited
Loading

pr: #36304
pr: #36714
pr: #36448

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing labels Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (5d5f899) to head (3933ba0).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #37673       +/-   ##
===========================================
- Coverage   80.61%   64.26%   -16.35%     
===========================================
  Files        1069      268      -801     
  Lines      166889    26464   -140425     
===========================================
- Hits       134534    17007   -117527     
+ Misses      27937     9457    -18480     
+ Partials     4418        0     -4418

see 801 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 14, 2024
@congqixia
Copy link
Contributor

/cc @zhuwenxing

congqixia
congqixia approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mergify mergify bot removed the ci-passed label Nov 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhuwenxing
add test
3933ba0 
Signed-off-by: lixinguo <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 15, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon, zhuwenxing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhuwenxing
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit b3e6482 into milvus-io:2.4 Nov 15, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@zhuwenxing zhuwenxing zhuwenxing approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@zhuwenxing zhuwenxing

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smellthemoon @congqixia @sre-ci-robot @zhuwenxing