Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Update the template expression proto to improve transmission efficiency #37484

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 6, 2024
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (f813fb4) to head (56f4130).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37484   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files         290      290           
  Lines       25377    25377           
=======================================
  Hits        17082    17082           
  Misses       8295     8295           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.31% <ø> (ø)
Go ∅ <ø> (∅)

@xiaocai2333 xiaocai2333 force-pushed the update_expression_proto branch from 80722d4 to 56f4130 Compare November 7, 2024 02:55
@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this pull request Nov 7, 2024
@mergify mergify bot added the ci-passed label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit de62764 into milvus-io:master Nov 7, 2024
18 of 20 checks passed
CaoHaiNam pushed a commit to CaoHaiNam/pymilvus that referenced this pull request Nov 7, 2024
@xiaocai2333 xiaocai2333 deleted the update_expression_proto branch November 8, 2024 03:11
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants