fix: watch channel stuck due to misuse of timer.Reset #37433
Conversation
mergify
bot
added
dco-passed
|
/lgtm |
|
@weiliu1031 go-sdk check failed, comment |
weiliu1031
force-pushed
the
fix_timer_reset
branch
from
0cd0863 to
956e826
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37433 +/- ##
===========================================
- Coverage 83.23% 67.31% -15.93%
===========================================
Files 1015 290 -725
Lines 157697 25377 -132320
===========================================
- Hits 131260 17082 -114178
+ Misses 21228 8295 -12933
+ Partials 5209 0 -5209
|
|
/run-cpu-e2e |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
fix_timer_reset
branch
from
956e826 to
c08a68f
Compare
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
weiliu1031
force-pushed
the
fix_timer_reset
branch
from
c08a68f to
39f412a
Compare
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
cause the misuse of timer.Reset, which cause dispatcher failed to send msg to virtual channel buffer, and dispatcher do splitting again and again, which hold the dispatcher manager's lock, block watching channel progress. This PR fix the misuse of timer.Reset Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
fix_timer_reset
branch
from
39f412a to
732f460
Compare
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
/lgtm |
issue: milvus-io#37166 cause the misuse of timer.Reset, which cause dispatcher failed to send msg to virtual channel buffer, and dispatcher do splitting again and again, which hold the dispatcher manager's lock, block watching channel progress. This PR fix the misuse of timer.Reset Signed-off-by: Wei Liu <[email protected]>
issue: #37166 pr: #37433 cause the misuse of timer.Reset, which cause dispatcher failed to send msg to virtual channel buffer, and dispatcher do splitting again and again, which hold the dispatcher manager's lock, block watching channel progress. This PR fix the misuse of timer.Reset Signed-off-by: Wei Liu <[email protected]>
issue: #37166
cause the misuse of timer.Reset, which cause dispatcher failed to send msg to virtual channel buffer, and dispatcher do splitting again and again, which hold the dispatcher manager's lock, block watching channel progress.
This PR fix the misuse of timer.Reset