Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process null value in yaml #37418

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Nov 4, 2024

issue: #34298
fix key: null defined in the yaml file.
viper will parse it as "", and yaml v3 will parse it as "null".

Signed-off-by: xianliang.li <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 4, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor

let's unblock deployment issue first, manual pass for a known e2e test

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (c27f477) to head (73ae9bb).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37418      +/-   ##
==========================================
- Coverage   83.24%   81.00%   -2.24%     
==========================================
  Files        1015     1305     +290     
  Lines      157453   182885   +25432     
==========================================
+ Hits       131064   148150   +17086     
- Misses      21192    29542    +8350     
+ Partials     5197     5193       -4     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <66.66%> (∅)
Go 83.26% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
pkg/config/config.go 80.00% <100.00%> (+1.73%) ⬆️

... and 316 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants