-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process null value in yaml #37418
Conversation
Signed-off-by: xianliang.li <[email protected]>
@foxspy cpp-unit-test check failed, comment |
rerun cpp-unit-test |
@foxspy E2e jenkins job failed, comment |
let's unblock deployment issue first, manual pass for a known e2e test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37418 +/- ##
==========================================
- Coverage 83.24% 81.00% -2.24%
==========================================
Files 1015 1305 +290
Lines 157453 182885 +25432
==========================================
+ Hits 131064 148150 +17086
- Misses 21192 29542 +8350
+ Partials 5197 5193 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #34298
fix key: null defined in the yaml file.
viper will parse it as "", and yaml v3 will parse it as "null".