Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix chunked segment term filter expression and add ut #37392

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: fix chunked segment term filter expression and add ut #37392

merged 3 commits into from
Nov 7, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 3, 2024 •
edited
Loading

issue: #37143

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 3, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.13%. Comparing base (7cfd609) to head (64fa3f2).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 9 Missing ⚠️
internal/core/src/mmap/ChunkedColumn.h 0.00% 8 Missing ⚠️
internal/core/src/exec/expression/Expr.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37392       +/-   ##
===========================================
- Coverage   83.23%   68.13%   -15.11%     
===========================================
  Files        1015      290      -725     
  Lines      157697    25395   -132302     
===========================================
- Hits       131260    17302   -113958     
+ Misses      21228     8093    -13135     
+ Partials     5209        0     -5209
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <39.56%> (∅)
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/exec/expression/TermExpr.cpp 82.95% <100.00%> (ø)
internal/core/src/exec/expression/Expr.h 75.08% <0.00%> (ø)
internal/core/src/mmap/ChunkedColumn.h 17.50% <0.00%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 14.86% <0.00%> (ø)

... and 1301 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaofan-luan
xiaofan-luan reviewed Nov 5, 2024
View reviewed changes
internal/core/src/exec/expression/TermExpr.cpp
@@ -137,9 +138,18 @@ PhyTermFilterExpr::CanSkipSegment() {
max = i == 0 ? val : std::max(val, max);
min = i == 0 ? val : std::min(val, min);
}
auto can_skip = [&]() -> bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way we can skip by chunk instead of skip by segment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way we can skip by chunk instead of skip by segment?

yes, we can check if a chunk can be skipped in search_pks function for this case.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@liliu-z
Copy link
Member

liliu-z commented Nov 7, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 7, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 7, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 7, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Collaborator

let's leave the skip chunk by chunk path into a seperate PR

@xiaofan-luan xiaofan-luan merged commit 40ba5a3 into milvus-io:master Nov 7, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunby @xiaofan-luan @liliu-z @czs007 @sre-ci-robot