Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Decouple shard client manager from shard cache #37371

Merged
merged 3 commits into from
Nov 12, 2024

fix review comment

f3b4481
Select commit
Loading
Failed to load commit list.
Merged

enhance: Decouple shard client manager from shard cache #37371

fix review comment
f3b4481
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 12, 2024 in 1s

68.13% (target 77.00%)

View this Pull Request on Codecov

68.13% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (5e90f34) to head (f3b4481).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5e90f34) and HEAD (f3b4481). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (5e90f34) HEAD (f3b4481)
4 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37371       +/-   ##
===========================================
- Coverage   80.58%   68.13%   -12.46%     
===========================================
  Files        1356      290     -1066     
  Lines      190009    25395   -164614     
===========================================
- Hits       153128    17302   -135826     
+ Misses      31475     8093    -23382     
+ Partials     5406        0     -5406     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

see 1066 files with indirect coverage changes