-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.4] Move forward l0 logic out of delta lock #37340
Conversation
Related to milvus-io#35303 `deleteMut` shall be protecting streaming delete buffer, forward l0 could be move out of the rlock section to reduce tsafe impact from loading segments. Signed-off-by: Congqi Xia <[email protected]>
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37340 +/- ##
==========================================
+ Coverage 79.05% 80.58% +1.53%
==========================================
Files 1061 1069 +8
Lines 164564 165657 +1093
==========================================
+ Hits 130088 133500 +3412
+ Misses 30108 27803 -2305
+ Partials 4368 4354 -14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick from master
pr: #37337
Related to #35303
deleteMut
shall be protecting streaming delete buffer, forward l0 could be move out of the rlock section to reduce tsafe impact from loading segments.