Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cp25]l0RowCount metrics value always empty #37308

Closed
wants to merge 1 commit into from
Closed

fix: [cp25]l0RowCount metrics value always empty #37308

wants to merge 1 commit into from

Conversation

XuanYang-cn
Copy link
Contributor

See also: #36953
pr: #37306

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 30, 2024
@XuanYang-cn XuanYang-cn changed the title fix: [cp24]l0RowCount metrics value always empty fix: [cp25]l0RowCount metrics value always empty Oct 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (8ba0a4a) to head (90e31e4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37308      +/-   ##
==========================================
+ Coverage   80.95%   83.24%   +2.28%     
==========================================
  Files        1305     1015     -290     
  Lines      182900   157474   -25426     
==========================================
- Hits       148069   131089   -16980     
+ Misses      29627    21187    -8440     
+ Partials     5204     5198       -6
Components Coverage Δ
Client ∅ <ø> (∅)
Core ∅ <ø> (∅)
Go 83.26% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.04% <100.00%> (ø)
internal/datacoord/segment_info.go 86.30% <100.00%> (+2.39%) ⬆️

... and 311 files with indirect coverage changes

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@XuanYang-cn XuanYang-cn closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuanYang-cn @sre-ci-robot