Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Check whether new collection name is alias (#36981) #37208

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #36981

Related to #36963


@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo October 28, 2024 10:04
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Oct 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 28, 2024
@congqixia congqixia added this to the 2.4.14 milestone Oct 28, 2024
@mergify mergify bot added the ci-passed label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (9c0f594) to head (bbd0392).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/meta_table.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37208      +/-   ##
==========================================
- Coverage   83.65%   80.53%   -3.13%     
==========================================
  Files         800     1068     +268     
  Lines      139161   165630   +26469     
==========================================
+ Hits       116422   133388   +16966     
- Misses      18382    27872    +9490     
- Partials     4357     4370      +13     
Files with missing lines Coverage Δ
internal/rootcoord/meta_table.go 85.19% <20.00%> (-0.32%) ⬇️

... and 292 files with indirect coverage changes

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit b44ef82 into milvus-io:2.4 Oct 28, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/36981 branch November 4, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants