fix: Search/Query may failed during updating delegator cache #37174
Conversation
casue init query node client is too heavy, so we remove updateShardClient from leader mutex, which cause much more concurrent cornor cases. This PR delay query node client's init operation until `getClient` is called, then use leader mutex to protect updating shard client progress to avoid concurrent issues. Signed-off-by: Wei Liu <[email protected]>
mergify
bot
added
dco-passed
Signed-off-by: Wei Liu <[email protected]>
| if err != nil { | ||
| return nil, err | ||
| return errors.Wrap(err, fmt.Sprintf("create client for node=%d failed", n.info.nodeID)) |
There was a problem hiding this comment.
Will the already created client be cleaned up before returning an error?
Signed-off-by: Wei Liu <[email protected]>
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37174 +/- ##
==========================================
- Coverage 80.58% 80.54% -0.05%
==========================================
Files 1066 1068 +2
Lines 165285 165638 +353
==========================================
+ Hits 133197 133414 +217
- Misses 27749 27859 +110
- Partials 4339 4365 +26
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #37115
pr: #37116
casue init query node client is too heavy, so we remove updateShardClient from leader mutex, which cause much more concurrent cornor cases.
This PR delay query node client's init operation until
getClientis called, then use leader mutex to protect updating shard client progress to avoid concurrent issues.