Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecoverage ommit #37114

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,11 @@ jobs:
kind: 'go'

integration-test:
if: false
name: Integration Test
needs: Build
runs-on: ubuntu-latest
timeout-minutes: 90
timeout-minutes: 120
steps:
- name: Maximize build space
uses: easimon/maximize-build-space@master
Expand Down Expand Up @@ -270,7 +271,7 @@ jobs:

codecov:
name: Upload Code Coverage
needs: [UT-Go, integration-test]
needs: [UT-Go]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand All @@ -282,10 +283,6 @@ jobs:
uses: actions/[email protected]
with:
name: go-result
- name: Download Integration Test coverage results
uses: actions/[email protected]
with:
name: it-result
- name: Display structure of code coverage results
run: |
ls -lah
Expand All @@ -295,17 +292,19 @@ jobs:
id: upload_cov
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./go_coverage.txt,./it_coverage.txt
files: ./go_coverage.txt
name: ubuntu-20.04-unittests
fail_ci_if_error: true
disable_safe_directory: true
verbose: true
- name: Retry Upload coverage to Codecov
if: ${{ failure() && github.repository == 'milvus-io/milvus' }}
uses: codecov/codecov-action@v4
id: retry_upload_cov
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./go_coverage.txt,./it_coverage.txt
files: ./go_coverage.txt
name: ubuntu-20.04-unittests
fail_ci_if_error: true
disable_safe_directory: true
verbose: true
4 changes: 2 additions & 2 deletions ci/jenkins/UT-CPP.groovy
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('jenkins-shared-library@v0.62.0') _
@Library('jenkins-shared-library@v0.63.0') _

def pod = libraryResource 'io/milvus/pod/tekton-4am.yaml'
def milvus_helm_chart_version = '4.2.8'
Expand Down Expand Up @@ -40,7 +40,7 @@ pipeline {
pullRequestNumber: "$env.CHANGE_ID",
make_cmd: "make clean && make USE_ASAN=ON build-cpp-with-coverage",
test_entrypoint: "./scripts/run_cpp_codecov.sh",
codecov_files: "./lcov_output.info,./it_coverage.txt"
codecov_files: "./lcov_output.info"
}
}
}
Expand Down
32 changes: 31 additions & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,40 @@ coverage:
if_ci_failed: error #success, failure, error, ignore

comment:
layout: "reach, diff, flags, files"
layout: "reach, diff, flags, components, files"
behavior: default
require_changes: false
branches: # branch names that can post comment
- master

component_management:
default_rules: # default rules that will be inherited by all components
statuses:
- type: project # in this case every component that doens't have a status defined will have a project type one
target: auto
branches:
- "!main"

individual_components:
- component_id: client
name: client
paths:
- client/**
- component_id: core
name: core
paths:
- internal/core/**
- component_id: cpp
name: cpp
paths:
- "**/*.c"
- "**/*.cpp"
- "**/*.h"
- component_id: go
name: go
paths:
- "**/*.go" # Includes all Go source files
- "!client/**" # Excludes the client component

ignore:
- "LICENSES"
Expand All @@ -42,3 +71,4 @@ ignore:




Loading