Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix collection leak in querynode (#37061) #37079

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bigsheeper
Copy link
Contributor

Unref the removed L0 segment count.

issue: #36918

pr: #37061

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels Oct 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 23, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (6bc8aba) to head (87ec207).
Report is 6 commits behind head on 2.4.

Files with missing lines Patch % Lines
tests/integration/util_query.go 83.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4   #37079   +/-   ##
=======================================
  Coverage   80.56%   80.57%           
=======================================
  Files        1066     1066           
  Lines      165211   165242   +31     
=======================================
+ Hits       133110   133150   +40     
+ Misses      27763    27751   -12     
- Partials     4338     4341    +3     
Files with missing lines Coverage Δ
internal/querynodev2/segments/collection.go 90.05% <100.00%> (+0.15%) ⬆️
internal/querynodev2/services.go 86.24% <100.00%> (-0.40%) ⬇️
tests/integration/suite.go 94.04% <100.00%> (+0.29%) ⬆️
tests/integration/util_query.go 86.34% <83.33%> (-0.40%) ⬇️

... and 32 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Oct 24, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 24, 2024
@czs007
Copy link
Contributor

czs007 commented Oct 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit da897e4 into milvus-io:2.4 Oct 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants