Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize BM25 err message #37074

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: optimize BM25 err message #37074

merged 1 commit into from
Oct 25, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #37022

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@zhengbuqian zhengbuqian mentioned this pull request Oct 24, 2024
Closed
1 task
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
optimize err message
c96203e 
Signed-off-by: Buqian Zheng <[email protected]>
@mergify mergify bot added the ci-passed label Oct 25, 2024
congqixia
congqixia approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 088d5d7 into milvus-io:master Oct 25, 2024
16 of 17 checks passed
@zhengbuqian zhengbuqian deleted the update-bm25-error-msg branch October 25, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@yah01 yah01 Awaiting requested review from yah01

Assignees

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbuqian @sre-ci-robot @congqixia