Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: [cherry pick]Add upsert in row test #36855

Merged
merged 4 commits into from
Oct 16, 2024
Merged

test: [cherry pick]Add upsert in row test #36855

merged 4 commits into from
Oct 16, 2024

Conversation

yanliang567
Copy link
Contributor

related issue: #36710
pr: #36820

@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. approved labels Oct 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/test labels Oct 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Update some error msg
0a620f0 
Signed-off-by: yanliang567 <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 15, 2024
@mergify mergify bot added the ci-passed label Oct 15, 2024
wangting0128
wangting0128 reviewed Oct 16, 2024
View reviewed changes
tests/python_client/milvus_client/test_milvus_client_insert.py
client_w.insert(client, collection_name, data,
check_task=CheckTasks.err_res, check_items=error)

@pytest.mark.tags(CaseLabel.L1)
@pytest.mark.xfail(reason="pymilvus issue 1895")
# @pytest.mark.xfail(reason="pymilvus issue 1895")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line of code just commented out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can deleted in next pr

wangting0128
wangting0128 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@wangting0128 wangting0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangting0128, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b90cda2 into milvus-io:2.4 Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 wangting0128 approved these changes

@binbinlv binbinlv Awaiting requested review from binbinlv

Assignees

@wangting0128 wangting0128

@binbinlv binbinlv

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/test lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanliang567 @sre-ci-robot @wangting0128 @binbinlv