Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enable parallel execution of L0 compactions #36816

Merged

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Oct 12, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 12, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby October 12, 2024 08:30
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.51%. Comparing base (b0d5866) to head (487840f).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36816   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files        1308     1308           
  Lines      156200   156199    -1     
=======================================
+ Hits       127324   127332    +8     
+ Misses      23753    23750    -3     
+ Partials     5123     5117    -6     
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 72.82% <0.00%> (-0.07%) ⬇️

... and 22 files with indirect coverage changes

@tedxu tedxu force-pushed the enhance/enable_parallel_L0_compaction branch from c293b03 to 949aeaf Compare October 14, 2024 02:29
@mergify mergify bot removed the ci-passed label Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu tedxu force-pushed the enhance/enable_parallel_L0_compaction branch from 949aeaf to 487840f Compare October 15, 2024 06:07
@mergify mergify bot added the ci-passed label Oct 17, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 605e089 into milvus-io:master Oct 17, 2024
15 of 16 checks passed
tedxu added a commit to tedxu/milvus that referenced this pull request Oct 18, 2024
sre-ci-robot pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants