Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: simplify ANTLR grammar definitions #36811

Closed
wants to merge 3 commits into from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Oct 12, 2024

See #36672

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Oct 12, 2024
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedxu
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 12, 2024
Copy link
Contributor

mergify bot commented Oct 12, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Oct 12, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 12, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@d45e267). Learn more about missing BASE report.
Report is 399 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36811   +/-   ##
=========================================
  Coverage          ?   72.45%           
=========================================
  Files             ?     1308           
  Lines             ?   155818           
  Branches          ?        0           
=========================================
  Hits              ?   112891           
  Misses            ?    37814           
  Partials          ?     5113           
Files with missing lines Coverage Δ
internal/parser/planparserv2/pool.go 92.30% <100.00%> (ø)
---- 🚨 Try these New Features:

Copy link

stale bot commented Nov 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 14, 2024
@stale stale bot closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants