Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Update antlr version and refine parsing not in #36745

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file labels Oct 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 10, 2024
@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 11, 2024
@sre-ci-robot sre-ci-robot merged commit d1060c0 into milvus-io:master Oct 11, 2024
14 checks passed
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (f7b8114) to head (71e0e5e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/parser/planparserv2/parser_visitor.go 89.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36745      +/-   ##
==========================================
- Coverage   82.44%   82.39%   -0.06%     
==========================================
  Files        1299     1301       +2     
  Lines      153084   153140      +56     
==========================================
- Hits       126217   126185      -32     
- Misses      21792    21887      +95     
+ Partials     5075     5068       -7     
Files with missing lines Coverage Δ
internal/parser/planparserv2/error_listener.go 100.00% <ø> (ø)
internal/parser/planparserv2/plan_parser_v2.go 89.09% <100.00%> (ø)
internal/parser/planparserv2/pool.go 92.30% <ø> (ø)
internal/parser/planparserv2/parser_visitor.go 89.85% <89.18%> (+0.51%) ⬆️

... and 36 files with indirect coverage changes

chasingegg added a commit to chasingegg/milvus that referenced this pull request Oct 30, 2024
@xiaocai2333 xiaocai2333 deleted the refine_parse_not_in branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants