-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add streaming client metrics #36523
enhance: add streaming client metrics #36523
Conversation
982ff08
to
c57d20f
Compare
Signed-off-by: chyezh <[email protected]>
4031a2c
to
e459ab5
Compare
Signed-off-by: chyezh <[email protected]>
e459ab5
to
8955d01
Compare
metrics.WALSegmentAllocTotal.DeletePartialMatch(m.constLabel) | ||
metrics.WALSegmentFlushedTotal.DeletePartialMatch(m.constLabel) | ||
metrics.WALPartitionTotal.Delete(m.constLabel) | ||
metrics.WALCollectionTotal.Delete(m.constLabel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WALSegmentBytes metric also needs to be cleaned up.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #33285