Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [skip e2e] Fix PR conflict in reduce unit test #36470

Merged

Conversation

congqixia
Copy link
Contributor

Related to #36433 #36180

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Sep 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 24, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@mergify mergify bot added ci-passed and removed ci-passed labels Sep 24, 2024
@sre-ci-robot sre-ci-robot merged commit ed95568 into milvus-io:master Sep 24, 2024
13 checks passed
@congqixia congqixia changed the title enhance: Fix PR conflict in reduce unit test enhance: [skip e2e] Fix PR conflict in reduce unit test Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (8cda48a) to head (0129330).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36470      +/-   ##
==========================================
+ Coverage   73.42%   82.33%   +8.91%     
==========================================
  Files        1278     1278              
  Lines      150875   150883       +8     
==========================================
+ Hits       110773   124226   +13453     
+ Misses      35115    21664   -13451     
- Partials     4987     4993       +6     

see 244 files with indirect coverage changes

@congqixia congqixia deleted the enhance/fix_reduce_ut_conflict branch September 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants