Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change pymilvus version for hybridsearch-groupby(#36407) #36451

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

MrPresent-Han
Copy link
Contributor

related: #36407

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/test sig/testing labels Sep 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Sep 23, 2024

/run-cpu-e2e

@MrPresent-Han MrPresent-Han force-pushed the change-pymilvus-version branch from d483284 to 17ca1eb Compare September 23, 2024 15:09
Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Sep 24, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 24, 2024
@yanliang567
Copy link
Contributor

the test part looks good to me if the issue was fixed by this change.

@mergify mergify bot added the ci-passed label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.33%. Comparing base (1833913) to head (2e7a2d5).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/search_reduce_util.go 81.81% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36451      +/-   ##
==========================================
+ Coverage   73.42%   82.33%   +8.91%     
==========================================
  Files        1277     1278       +1     
  Lines      150832   150870      +38     
==========================================
+ Hits       110749   124226   +13477     
+ Misses      35110    21655   -13455     
- Partials     4973     4989      +16     
Files with missing lines Coverage Δ
internal/proxy/search_reduce_util.go 86.74% <81.81%> (+0.53%) ⬆️

... and 249 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d55d9d6 into milvus-io:master Sep 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants