Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected shrotcut when proxy reducing(#36407) #36428

Closed

Conversation

MrPresent-Han
Copy link
Contributor

related: #36407

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 23, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 23, 2024
@tedxu
Copy link
Contributor

tedxu commented Sep 23, 2024

/lgtm

Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (3b01b7d) to head (191752c).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/search_reduce_util.go 81.81% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36428      +/-   ##
==========================================
+ Coverage   73.39%   82.35%   +8.95%     
==========================================
  Files        1277     1277              
  Lines      150749   150829      +80     
==========================================
+ Hits       110646   124216   +13570     
+ Misses      35117    21631   -13486     
+ Partials     4986     4982       -4     
Files with missing lines Coverage Δ
internal/proxy/search_reduce_util.go 86.74% <81.81%> (+0.53%) ⬆️

... and 255 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 23, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

/hold

@MrPresent-Han
Copy link
Contributor Author

/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants